Implement std::error::Error for errors #256
Conversation
fbf6e37 to
ff679e1
Compare
| } | ||
| } | ||
|
|
||
| impl<'i> Error for BasicParseError<'i> {} |
There was a problem hiding this comment.
Why did you not implement description here?
There was a problem hiding this comment.
The documentation for Error says: "This method is soft-deprecated. Although using it won’t cause compilation warning, new code should use Display instead and new impls can omit it."
There was a problem hiding this comment.
Please implement it anyway, calling BasicParseErrorKind::description.
|
@SimonSapin @nox Could someone take another look at this PR? |
| } | ||
| } | ||
|
|
||
| impl<'i> Error for BasicParseError<'i> {} |
There was a problem hiding this comment.
Please implement it anyway, calling BasicParseErrorKind::description.
| @@ -62,6 +76,14 @@ pub struct BasicParseError<'i> { | |||
| pub location: SourceLocation, | |||
| } | |||
|
|
|||
| impl<'i> fmt::Display for BasicParseError<'i> { | |||
| fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result { | |||
| write!(formatter, "{}", self.kind.description()) | |||
There was a problem hiding this comment.
This won't print enough information, i.e. we end up not printing the payloads of UnexpectedToken(_) and AtRuleInvalid(_).
| write!(formatter, "{}", match &self.kind { | ||
| ParseErrorKind::Basic(basic_kind) => basic_kind.description(), | ||
| ParseErrorKind::Custom(_) => "Custom error", | ||
| }) |
There was a problem hiding this comment.
Please put the match outside and avoid write!.
match &self.kind {
ParseErrorKind::Basic(basic) => basic.fmt(formatter),
ParseErrorKind::Custom(_) => "custom error".fmt(formatter),
}| fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result { | ||
| write!(formatter, "{}", match &self.kind { | ||
| ParseErrorKind::Basic(basic_kind) => basic_kind.description(), | ||
| ParseErrorKind::Custom(_) => "Custom error", |
There was a problem hiding this comment.
Why is the payload disregarded here?
| } | ||
| } | ||
|
|
||
| impl<'i, T> Error for ParseError<'i, T> where T: fmt::Debug {} |
This change is
Fixes #247.