Minor rules and declaration cleanups. #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@bors-servo r+
|
Contributor
|
📌 Commit 48b8f0f has been approved by |
Contributor
bors-servo
added a commit
that referenced
this pull request
Apr 27, 2023
Minor rules and declaration cleanups. None
Contributor
|
💔 Test failed - checks-github |
e706b09 to
bd27360
Compare
Member
Author
|
@tiaanl @SimonSapin @jdm any objection on bumping MSRV to 1.63 which fixes the bugs that we were working around in #254? Seems already old-ish enough, and allows #256 to get through too. I'm going to rejigger some of this code for nesting and it'd be good not having to think about the weird lifetime inference bug. |
Member
|
No objection! |
Member
Author
|
@bors-servo r+ Alright then :) |
Contributor
|
📌 Commit bd27360 has been approved by |
Member
Author
|
Well actually, since there's a release pending, let me do that first. @bors-servo r- |
Member
Author
|
@bors-servo r+ |
Contributor
|
📌 Commit bd27360 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.