node.isColor does not support rgb(a), hsl(a) and color keywords #64
Labels
Comments
|
Absolutely. In the future please do use the issue templates. |
|
updated opening comment |
shellscape
added a commit
that referenced
this issue
Feb 6, 2019
|
Added in 7108d9a. I'll release a new beta shortly. |
|
Whoa, that’s quick! |
shellscape
added a commit
that referenced
this issue
Mar 3, 2019
* chore: updating metadata, ci, project structure * chore: starting fresh with a tokenizer * fix: fix token position for paren and comma splits * feat: operator node * chore: license * chore: additional node support * test: get numeric tests working * chore: fix linting * test: fix local npm audit * test: punctuation tests * test: unicode range tests * refactor: mature the codebase * fix: operator split regex, remove modulo * feat: function nodes * feat: interpolation and variable support * chore: knocking down errors * chore: ongoing * test: add test to cover failed url from #62 * test: add operator tests * feat: implement type walkers * fix: hex colors * fix: oddball word parsing * test: update snapshots to v2, fix operator before word * test: improve coverage, weed out dead code * chore: update dependencies * fix: numeric units, update snapshots * fix: modulo operator * chore: rename atrule, create AtWord * docs: rewrite docs wip * docs: wip * docs: finishing up docs for release * chore(release): beta2. publish only needed files * fix: remove global flag from shared regexps. fixes #63 * feat: function.isColor, isColor for color names. fixes #64 * chore(release): beta3 * fix: protocol-relative urls. fixes #65. adds isUrl to Word * chore(release): 3.0.0-beta.4 * chore: add performance benchmark * chore: devDep update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Feature Use Case
For convenience and accuracy it would be nice if
node.isColorwould also recognizehsl(),hsla(),rgb(),rgba()and color keyword (blue,yellow) nodes.Feature Proposal
For @projectwallace/css-analyzer I use this logic to determine whether a node is a color.
The text was updated successfully, but these errors were encountered: