Skip to content

isColor does not detect capitalized color keywords #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bartveneman opened this issue Mar 3, 2019 · 3 comments
Closed

isColor does not detect capitalized color keywords #67

bartveneman opened this issue Mar 3, 2019 · 3 comments

Comments

@bartveneman
Copy link

bartveneman commented Mar 3, 2019

  • Webpack Version: N/A
  • Operating System (or Browser): Mac OS 10.14.3
  • Node Version: 10.15.2
  • postcss-values-parser Version: 3.0.0-beta.4

How Do We Reproduce?

const {parse} = require('postcss-values-parser')

;['Red', 'GREEN', 'whiteSmoke'].forEach(color => {
  parse(color, {loose: true}).walk(node => {
    console.log(node.isColor)
  })
})

Expected Behavior

Expected isColor to be true for all of these cases

Actual Behavior

isColor is false for all of these cases

Related issues and code

@shellscape
Copy link
Owner

Good catch. Should be an easy fix.

@shellscape
Copy link
Owner

Fixed and released in v3.0.0 proper. We're out of beta. Thank you for your help in adopting the beta!

@bartveneman
Copy link
Author

Whoo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants