Duplicate field group label Ids#166
Merged
mobywhale-chan merged 3 commits intostubbornella:masterfrom Sep 26, 2013
pflannery:Duplicate-Field-Group-Labels
Merged
Duplicate field group label Ids#166mobywhale-chan merged 3 commits intostubbornella:masterfrom pflannery:Duplicate-Field-Group-Labels
mobywhale-chan merged 3 commits intostubbornella:masterfrom
pflannery:Duplicate-Field-Group-Labels
Conversation
added 3 commits
July 30, 2013 21:18
Field Group Label->"For" attributes were all referencing the same Id so when you click the second+ label in the group it always selected the first radio item.
Renamed the Id to singleLabelText1
Owner
|
This looks good to me. @arnogues @mobywhale-chan |
Collaborator
|
LGTM |
mobywhale-chan
added a commit
that referenced
this pull request
Sep 26, 2013
Duplicate field group label Ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field Group Label->Id & For attributes were all referencing the same Id so
when you clicked the second+ label in the group it always selected the
first Field Group Item.