Skip to content

Duplicate field group label Ids #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mobywhale-chan merged 3 commits into from
Sep 26, 2013
Merged

Duplicate field group label Ids #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d5ba97
Fixed duplicate Field Group Label->For attributes
Jul 30, 2013
09f2306
Fixed duplicate field group ids for email and select
Jul 30, 2013
b75df0b
Fixed single label using duplicate text1 id
Jul 30, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions oocss/src/components/form/fieldGroup/fieldGroup.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
{{#ffield}}
{{#flabel "" "fieldLabel"}}Your email addresses{{/flabel}}
{{#fgroup}}
{{#repeat 2 "inputblock"}}
{{#repeat 2 "emailInputblock"}}
{{#fgroupitem "ftext" @indexStr "" ""}}Email address {{@index}}{{/fgroupitem}}
{{/repeat}}
{{/fgroup}}
Expand All @@ -72,7 +72,7 @@
{{#ffield}}
{{#flabel "" "fieldLabel"}}Select your options{{/flabel}}
{{#fgroup}}
{{#repeat 2 "inputblock"}}
{{#repeat 2 "selectInputblock"}}
{{#fgroupitem "fselect" @indexStr "" "" "" "" "" 2}}Option {{@index}}{{/fgroupitem}}
{{/repeat}}
{{/fgroup}}
Expand Down
4 changes: 2 additions & 2 deletions oocss/src/components/form/form_doc.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@
<p>Add class <code>labelLeft</code> to <code>label</code>.</p>
{{#formpres "" "" "htmlcode"}}
{{#ffield}}
{{#flabel "text1" "labelLeft fieldLabel"}}Label on the left{{/flabel}}
{{#ftext "text1"}}{{/ftext}}
{{#flabel "singleLabelText1" "labelLeft fieldLabel"}}Label on the left{{/flabel}}
{{#ftext "singleLabelText1"}}{{/ftext}}
{{/ffield}}
{{/formpres}}
<h5>Multiple fields with label on left</h5>
Expand Down
3 changes: 2 additions & 1 deletion oocss/tools/files/handlebars.helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ var Handlebars,
max = max*1; // parseint
for (var i = start; i <= max; i++) {
data.index = i;
data.indexStr = indexPrefix;
/* appends index to the indexStr so it's unique */
data.indexStr = indexPrefix + i;
str.push(options.fn(this, {data: data}));
}
return str.join('');
Expand Down