Fix flex shorthand transformation #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues were fixed - now suppports all shorthand variations (grow/shrink/basis, grow/shrink, and grow). Previously it didn't support grow/shrink - Also allows `0` as a value for grow/shrink. Because the logic checked `token.match(NUMBER)` directly, a zero value evaluated as false.
jacobp100
added a commit
that referenced
this pull request
May 15, 2017
Contributor
|
I've fixed this in another branch. In terms of the flex order, it should be spec compliant. I'm not too sure what cases you were trying to get to work, but if you think there's a case or two missing, feel free to open another bug! But thanks anyway for helping! |
Author
|
I think your fix was good! |
mxstbr
added a commit
that referenced
this pull request
May 22, 2017
Fix parsing various shorthands when a value is zero (fixes #38)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues were fixed
0as a value for grow/shrink. Because the logic checkedtoken.match(NUMBER)directly, a zero value evaluated as false.resolves #37