Skip to content

Fix parsing various shorthands when a value is zero (fixes #38) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2017
Merged

Fix parsing various shorthands when a value is zero (fixes #38) #39

merged 3 commits into from
May 22, 2017

Conversation

jacobp100
Copy link
Contributor

@jacobp100 jacobp100 commented May 15, 2017 •
edited
Loading

The issue is that tokenStream.match(NUMBER) when given "0" would return zero, which is falsy. I've removed this match functionality, as it was rarely used in that way in the first place.

Commit message was wrong: fixes #37

apexskier
apexskier reviewed May 15, 2017
View reviewed changes
Copy link

@apexskier apexskier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this can close #38 (it replaces it)

@jacobp100
Copy link
Contributor Author

@mxstbr

@mxstbr mxstbr merged commit 17adff0 into master May 22, 2017
@jacobp100 jacobp100 deleted the fix-zero-literal-matches branch May 22, 2017 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apexskier apexskier apexskier left review comments

@mxstbr mxstbr mxstbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Failed to parse declaration "flex: 0 1"
3 participants
@jacobp100 @apexskier @mxstbr