line-height: throw an error when using a multiplier #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we do this as a separate dev-only validation step rather than treating this as a transform? That way it’ll be easier to add support for other properties too! |
|
Sure, I'm just not sure what you mean by "dev-only validation step", maybe you can clarify that a bit? :) |
|
I'll try and get a PR this weekend! |
|
Nice, ping me when you are ready with your PR. |
|
@jacobp100 I did not want to disturb you, but is there something I can help with? It would be nice to fix using line-height with a multiplier value :) |
|
Sorry, I just put together a really quick example of this. #92 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an error when a multiplier is used as a value for
line-height.Fixes #89
@jacobp100 Let me know if you want this to be handled in a different way.