Skip to content
This repository was archived by the owner on Feb 9, 2023. It is now read-only.

Update dependencies #43

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Update dependencies #43

merged 1 commit into from
Sep 14, 2020

Conversation

abdonrd
Copy link

@abdonrd abdonrd commented Sep 14, 2020

Which issue, if any, is this issue related to?

None, as it's a documentation fix.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

You'll want to merge #40 first, and then rebase this pull request before merging it.

@abdonrd
Copy link
Author

abdonrd commented Sep 14, 2020

@jeddy3 I didn't update mocha, nyc and chai in this PR to avoid conflicts!

@jeddy3
Copy link
Member

jeddy3 commented Sep 14, 2020

@jeddy3 I didn't update mocha, nyc and chai in this PR to avoid conflicts!

Unfortunately, it looks like it conflicted anyway. Can you rebase?

@abdonrd
Copy link
Author

abdonrd commented Sep 14, 2020

@jeddy3 right! rebased! ⚡

@jeddy3
Copy link
Member

jeddy3 commented Sep 14, 2020

Thank you! Go ahead and merge this PR, if you like.

@abdonrd abdonrd merged commit 1fc2e15 into master Sep 14, 2020
@abdonrd abdonrd deleted the update-deps branch September 14, 2020 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants