Fix suggestion of utilities with slashes in them in v4 #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All utilities implicitly have at least `modifiers: []` in the class list when no modifiers are present. We should only change the completion list when there are actually modifiers to show in case an existing utility with a slash in it (e.g. `w-1/2`) is “close” to what the user has typed.
thecrypticace
added a commit
to tailwindlabs/tailwindcss
that referenced
this pull request
Feb 11, 2025
Fixes tailwindlabs/tailwindcss-intellisense#1178 (partially) An IntelliSense PR (+ Play update) is required to make this work better with v4: tailwindlabs/tailwindcss-intellisense#1182 <img width="671" alt="Screenshot 2025-02-07 at 15 19 59" src="https://github.com/user-attachments/assets/7642b80c-f431-4a1e-964d-2a98ffe7a67a" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All utilities implicitly have at least
modifiers: []in the class list when no modifiers are present. We should only change the completion list when there are actually modifiers to show in case an existing utility with a slash in it (e.g.w-1/2) is “close” to what the user has typed.This is the other half to fix #1178 b/c while the completions show up but as soon as you type
/they disappear which is an awful experience.