Skip to content

Fix suggestion of utilities with slashes in them in v4 #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 3 commits into from
Feb 10, 2025
Merged

Fix suggestion of utilities with slashes in them in v4 #1182

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36c5941
Fix suggestion of utilities with slashes in them in v4
thecrypticace Feb 7, 2025
a7a7928
Update changelog
thecrypticace Feb 7, 2025
db611fe
Merge branch 'main' into fix/handle-slash-suggestions
thecrypticace Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix suggestion of utilities with slashes in them in v4 
All utilities implicitly have at least `modifiers: []` in the class list when no modifiers are present. We should only change the completion list when there are actually modifiers to show in case an existing utility with a slash in it (e.g. `w-1/2`) is “close” to what the user has typed.
  • Loading branch information
@thecrypticace
thecrypticace committed Feb 7, 2025
commit 36c59413fb4c6e65db41bab75522b966699bc024
7 changes: 4 additions & 3 deletions packages/tailwindcss-language-service/src/completionProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@ export function completionsFromClassList(
let beforeSlash = partialClassName.split('/').slice(0, -1).join('/')

let baseClassName = beforeSlash.slice(offset)
modifiers = state.classList.find((cls) => Array.isArray(cls) && cls[0] === baseClassName)?.[1]
?.modifiers
modifiers =
state.classList.find((cls) => Array.isArray(cls) && cls[0] === baseClassName)?.[1]
?.modifiers ?? []

if (modifiers) {
if (modifiers.length > 0) {
return withDefaults(
{
isIncomplete: false,
Expand Down