-
Notifications
You must be signed in to change notification settings - Fork 215
Add color format options (rgb, hex) #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color format options (rgb, hex) #831
Conversation
I would absolutely LOVE this! |
Any feedback would be much appreciated @bradlc! |
Any update? Bump. This is really needed feature. |
I took the latest version (0.10.0) of this extension, applied this PR, and published it as a new vscode extension. I don't plan on maintaining it long term but my team couldn't wait any longer for this feature. Thought I'd post it here in case it helps anyone else. https://marketplace.visualstudio.com/items?itemName=numso.vscode-tailwindcss-with-hex-colors (aside: wouldn't it be amazing if you could use https://www.npmjs.com/package/patch-package on vscode extensions??) |
mark |
Very helpful |
@thecrypticace Hope to merge this PR, it's very helpful |
When will this be merged? |
+1, we need this please!! |
Someone merge the PR, please |
@flostellbrink resolve the conflicts please 🙏 |
Unfortunately a rebase is out of the questions at the moment. I need to test the changes, and master has been broken for three weeks straight now. Either way I have no reason to believe anyone at tailwind actually wants this. Only leaving the PR open to avoid duplicate work. |
Formats are displayed in completions and as comments in hovered css. This helps with comparing code to designs.
This will give us a guaranteed way to isolate global state in tests
b5c9b2b
to
5265779
Compare
Hey, I'm going to be adding support for this but in a slightly different form. I think we can get rid of the color format option as well as simplify some things. We're working on v4 right now but I expect I'll pick this back up possibly next week unless I happen to get to it sooner. |
This has been merged and should be available in the pre-release build shortly. Thanks! |
Formats are displayed in completions and as comments in hovered css. This helps with comparing code to designs.
This is basically an up to date version of #416 and fixes #418.
Makes it trivial to add more color formats going forward if people need them.
Settings:
Completions:
Hovers: