fix: bump enhanced-resolve for upstream fix
#907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the following is broken:
```javascript
module.exports = require('@acme/ui/tailwind.config.cjs')
```
where `@acme/ui` has:
```json
"exports": {
"./*.cjs": "./*.cjs",
},
```
and requires the following workaround
```json
"exports": {
"./tailwind.config.cjs": "./tailwind.config.cjs",
"./*.cjs": "./*.cjs",
},
```
bumping the package fixes this.
a1e2e40 to
87792ca
Compare
Contributor
Author
|
Sorry, I just noticed webpack/enhanced-resolve#301 still hasn't been merged. In that case there would be a need to rebase |
Contributor
|
Hey, thanks for this — I'll take a look soon! |
43081j
added a commit
to 43081j/tailwindcss-intellisense
that referenced
this pull request
May 21, 2024
Builds on tailwindlabs#907 but bumps the version of enhanced-resolve to latest. Also drops a `replace` which should now be solved inside enhanced-resolve itself.
43081j
added a commit
to 43081j/tailwindcss-intellisense
that referenced
this pull request
May 21, 2024
Builds on tailwindlabs#907 but bumps the version of enhanced-resolve to latest. Also drops a `replace` which should now be solved inside enhanced-resolve itself.
Contributor
|
Closing in favor of #971 — looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Sorry, I just noticed webpack/enhanced-resolve#301 still hasn't been merged. In that case there would be a need to rebase enhanced-resolve-301 instead of this.
This pulls in webpack/enhanced-resolve#353.
Otherwise, the following is broken (webpack/enhanced-resolve#352):
where
@acme/uihas:and requires the following workaround
Bumping the package fixes this. The
tailwindcss-language-servercode has a comment referencing webpack/enhanced-resolve#282, but that's been fixed upstream so I'm not sure if it's still a blocker for this.