chore: bump enhanced-resolve version #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the following is broken:
```javascript
module.exports = require('@acme/ui/tailwind.config.cjs')
```
where `@acme/ui` has:
```json
"exports": {
"./*.cjs": "./*.cjs",
},
```
and requires the following workaround
```json
"exports": {
"./tailwind.config.cjs": "./tailwind.config.cjs",
"./*.cjs": "./*.cjs",
},
```
bumping the package fixes this.
Builds on tailwindlabs#907 but bumps the version of enhanced-resolve to latest. Also drops a `replace` which should now be solved inside enhanced-resolve itself.
|
Ah fantastic they've finally merged the fix. I'm gonna to do some testing to verify that things work and will get this merged probably tomorrow. |
|
I tried to create a project similar to what was being fixed originally but it doesn't work in the existing extension 🙃 This doesn't seem to break other things though so I'm going to roll with it for now and will keep an eye out for PnP related issues. Thanks! |
|
thanks for taking a look 🙏 if any issues do come up, give me a shout and ill be happy to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #907 but bumps the version of enhanced-resolve to latest.
Also drops a
replacewhich should now be solved inside enhanced-resolve itself.tests seem to pass but i'm not aware of a specific one to test what the
replacewas fixing/working around. if someone can point me in the right direction, im happy to add one