Remove all @keyframes in reference import mode
#15581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecd2e6d to
21bc021
Compare
@keyframes in reference mode@keyframes in reference import mode
philipp-spiess
commented
Jan 9, 2025
Comment on lines
+223
to
+225
| if (!referenceMode) { | ||
| ast.push(rule(name, objectToAst(css))) | ||
| } |
There was a problem hiding this comment.
This was the place where previously it's possible to sneak-through @keyframes even when the plugin is inside an @reference import
21bc021 to
c7dedf6
Compare
RobinMalfait
reviewed
Jan 9, 2025
RobinMalfait
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where JavaScript plugins were still able to contribute
@keyframeswhen loaded inside an@referenceimport. This was possible because we only gated theaddBaseAPI and not theaddUtilitiesone which also has a special branch to handle@keyframerules.To make this work, we have to create a new instance of the plugin API that has awareness of wether the plugin accessing it is inside reference import mode.
Test plan
Added a unit test that reproduces the issue observed via #15544