Dev #606
Merged
Dev #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix seeming deviation from intent, although not in a likely meaningful way.
…plify formatting of output string by eliminating 'magic' 101 values.
…n of the negation of date.getTimezoneOffset() to make it clear that we need to reverse its sense. Just representing it as straight subtraction might be mathematically simpler and marginally more performant, but would fail to suggest this important detail.
…mentational, but that's all the methods under test do.
…hough I haven't tested its datepicker collaborator functions.
…tion tested for null with typed equality. Changed to test for falsiness.
…, make splitDateTime() return an object instead of an array to simplify the code a bit.
…ave the corresponding variants of splitDateTime() because it still exercises other important facets of the algorithm.
trentrichardson
added a commit
that referenced
this pull request
Jul 15, 2013
More tests added, cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Trent --
A lot more coverage, a few bugs, and a some cleanup. This is the last of the changes that are covered by the narrative of the book, but I'm going to continue working on it to try to cover the whole thing.
Let me know if you have any questions or issues with the changes. I've tried to give good commit messages.
Steve