Code

Dev#606

Code

Merged

trentrichardson merged 25 commits intotrentrichardson:devtrentrichardson/jQuery-Timepicker-Addon:devfrom

srvance:devsrvance/jQuery-Timepicker-Addon:devCopy head branch name to clipboard

Jul 15, 2013

Commits

Commits on Jul 8, 2013

• Start tests for timepicker functions. Test timezoneOffsetNumber() and fix seeming deviation from intent, although not in a likely meaningful way.

  srvance

  committed
  83b6840

  Copy full SHA for 83b6840

• Expand timezoneOffsetNumber() docs

  srvance

  committed
  7bc2133

  Copy full SHA for 7bc2133

Commits on Jul 9, 2013

• Test timepicker.timezoneOffsetString(). Fix lower range issue and simplify formatting of output string by eliminating 'magic' 101 values.

  srvance

  committed
  4b34372

  Copy full SHA for 4b34372

Commits on Jul 13, 2013

• Fix some jsdoc.

  srvance

  committed
  1adc385

  Copy full SHA for 1adc385

• Test timepicker.log()

  srvance

  committed
  7c389ba

  Copy full SHA for 7c389ba

• Test timepicker.timezoneAdjust()

  srvance

  committed
  b23be92

  Copy full SHA for b23be92

• Minor simplification of timepicker.timezoneAdjust(). Left the addition of the negation of date.getTimezoneOffset() to make it clear that we need to reverse its sense. Just representing it as straig…

  Show description for af26afc
  srvance

  committed
  af26afc

  Copy full SHA for af26afc

• Test the callers of timepicker.handleRange. The tests are a bit implementational, but that's all the methods under test do.

  srvance

  committed
  9254a37

  Copy full SHA for 9254a37

• Doco fix.

  srvance

  committed
  fe89724

  Copy full SHA for fe89724

• Simplify range convenience function tests.

  srvance

  committed
  afb4c98

  Copy full SHA for afb4c98

• Add placeholder for handleRange, but I'm not quite ready to tackle that one yet.

  srvance

  committed
  f363202

  Copy full SHA for f363202

Commits on Jul 14, 2013

• Expose splitDateTime for testing.

  srvance

  committed
  ff99363

  Copy full SHA for ff99363

• Tests for splitDateTime, except for error paths.

  srvance

  committed
  f589d84

  Copy full SHA for f589d84

• Expose parseDateTimeInternal for testing. I'm going to test it even though I haven't tested its datepicker collaborator functions.

  srvance

  committed
  b2633f1

  Copy full SHA for b2633f1

• Tests for parseDateTimeInternal(). The exception test found a bug.

  srvance

  committed
  1cc967a

  Copy full SHA for 1cc967a

• Fix parseDateTimeInternal() bug. The parsers returned false. The function tested for null with typed equality. Changed to test for falsiness.

  srvance

  committed
  c264915

  Copy full SHA for c264915

• Refactored parseDateTimeInternal() to make it a little simpler to read and test.

  srvance

  committed
  353ff5e

  Copy full SHA for 353ff5e

• Now that the basic time and date parsing functions are test protected, make splitDateTime() return an object instead of an array to simplify the code a bit.

  srvance

  committed
  f3456ce

  Copy full SHA for f3456ce

• Eliminate an unused intermediate variable.

  srvance

  committed
  5109082

  Copy full SHA for 5109082

• Refactor the effective setting computations out of splitDateTime()

  srvance

  committed
  11a2545

  Copy full SHA for 11a2545

• Write direct tests for the new computeEffectiveSetting() function. Leave the corresponding variants of splitDateTime() because it still exercises other important facets of the algorithm.

  srvance

  committed
  ea7babe

  Copy full SHA for ea7babe

• I dug into the project history to figure out how to test the error path of splitDateTime() and discovered that the code that motivated the error path was replaced but the error handling it required…

  Show description for 6adc077
  srvance

  committed
  6adc077

  Copy full SHA for 6adc077

• Refactor splitDateTime() signature to eliminate two unused parameters.

  srvance

  committed
  f50fc08

  Copy full SHA for f50fc08

Commits on Jul 15, 2013

• Refactor the dateFormat in the parseDateTimeInternal tests.

  srvance

  committed
  bb7e010

  Copy full SHA for bb7e010

• Use the alias for the timepicker utils to simplify the tests.

  srvance

  committed
  032adf1

  Copy full SHA for 032adf1