Skip to content

rename StyleValue.cssString to cssText #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heycam opened this issue Jan 30, 2016 · 0 comments
Closed

rename StyleValue.cssString to cssText #104

heycam opened this issue Jan 30, 2016 · 0 comments
Labels
css-typed-om-1

Comments

@heycam
Copy link
Contributor

heycam commented Jan 30, 2016

That would match other CSSOM string serialization IDL attributes.
@shans shans closed this as completed in 417ab62 Jan 30, 2016
shans added a commit that referenced this issue Jan 30, 2016
@shans
Merge pull request #108 from heycam/rename-cssString
c6edc53 
Rename cssString to cssText (fixes #104)
majido added a commit to majido/css-houdini-drafts that referenced this issue Aug 8, 2018
@majido
Use webidl algorithms for construction and invocation (w3c#104)
2626450 
We resolved to continue using the "cache" props approach [here](w3c#743 (comment)) but  we still need to be consistent in using webidl algorithms for invoking and construction operation.

The following changes fix this:
 - Use VoidFunction type for constructor, and Function type for animate and destroy callbacks
 - Use  convert algorithm to convert incoming values to proper types upon registration
 - Use invoke/construct algorithms to call or construct. This ensure the proper  setup in place which addresses the original reported issue.

Fixes w3c#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-typed-om-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@heycam