[css-typed-om] Small readability fix #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabatkins
added a commit
that referenced
this pull request
Jan 19, 2016
[css-typed-om] Small readability fix
majido
added a commit
to majido/css-houdini-drafts
that referenced
this pull request
Aug 8, 2018
We resolved to continue using the "cache" props approach [here](w3c#743 (comment)) but we still need to be consistent in using webidl algorithms for invoking and construction operation. The following changes fix this: - Use VoidFunction type for constructor, and Function type for animate and destroy callbacks - Use convert algorithm to convert incoming values to proper types upon registration - Use invoke/construct algorithms to call or construct. This ensure the proper setup in place which addresses the original reported issue. Fixes w3c#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.