-
Notifications
You must be signed in to change notification settings - Fork 142
[css-properties-values-api] When can reifying a registered prop's value ever hit step 7? #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/cc @andruud |
You mean we have to set the
I tried to express concern about this previously, but probably failed to do it clearly. What I wanted to do here (without quite knowing how), was catch the case where the underlying value is a value without additional type attached to it (and part of my concern previously was whether the idea that underlying values "have a type" is a valid concept in the spec universe---naturally it's a valid concept in Blink). In other words, it should catch values that result from Since
Won't that cause |
Currently, yes. That algo requires you to pass a value and a property name.
I don't quite understand what you mean by this. Can you elaborate?
Ah, yes, that's not what we want. Since So yeah, then, step 6's condition should be "grammar isn't |
Er, I'll try, although it's clearly not going well so far. 😛 Rephrased question: If I parse a string against |
Currently, step 7 of the computed-value reifying algorithm https://drafts.css-houdini.org/css-properties-values-api/#reify-a-registered-custom-property-value says to reify as a CSSStyleValue, if all the previous steps failed.
This isn't correct as-is (it needs to specify what property it's for), but also, I'm not sure how it could ever hit that case in the first place. Step 6 catches if it's a <declaration-value> already, and since it's the value of a declaration that you're reifying, that seems to catch 100% of cases, right?
So I think instead we should delete step 7, and change step 6 to just be an "otherwise", without a further condition.
The text was updated successfully, but these errors were encountered: