Skip to content

[css-properties-values-api] Define effects on CSSOM. #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

andruud
Copy link
Member

@andruud andruud commented Apr 4, 2019

  • Define how setProperty() behaves for registered custom properties.
  • Define how values reify.
  • How underlying values are created is not defined, as I think the
    current description in css-typed-om covers it.

 * Define how setProperty() behaves for registered custom properties.
 * Define how values reify.
 * How underlying values are created is not defined, as I _think_ the
   current description in css-typed-om covers it.
@andruud
Copy link
Member Author

andruud commented Apr 4, 2019

This is the final missing "substantial" piece of this spec, I think.

Not sure if it's OK to use <declaration-value> in this way. CSS Typed OM seems to have a concept of underlying values "being" a certain type (rather than e.g. matching a production), in which case it should be fine.

@tabatkins tabatkins merged commit 8cbccbd into w3c:master Apr 25, 2019
@tabatkins
Copy link
Member

Did some minor tweaking to wording and linking, but nothing to the algos. Looks good otherwise, sorry for the delay in reviewing.

CSS Typed OM seems to have a concept of underlying values "being" a certain type (rather than e.g. matching a production), in which case it should be fine.

Yeah, underlying values are an implementation-defined structure, that just must be able to reproduce the necessary data for reification/stringification. What you have down is fine; the only thing that's not a <declaration-value> but still a valid custom property value is the empty value, and that can't ever match a syntax, so it's fine to let that fall into the second case.

@andruud
Copy link
Member Author

andruud commented Apr 26, 2019

Thanks Tab 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants