-
Notifications
You must be signed in to change notification settings - Fork 142
Add a few examples to the reification table #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -3574,6 +3574,11 @@ which will be filled in with more detail as we go. | |||
|
|||
: <a>align-content</a> | |||
:: | |||
1. If the specified or computed value is the ''normal'' keyword, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can either do this, or have separate tables for specified vs computed (will have duplications)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on the property. align-content has the same behavior in specified and computed, so we can combine them.
@@ -3574,6 +3574,11 @@ which will be filled in with more detail as we go. | |||
|
|||
: <a>align-content</a> | |||
:: | |||
1. If the specified or computed value is the ''normal'' keyword, | |||
return the result of reifying the "normal" keyword. | |||
2. If the value is a keyword from <<content-distribution>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this legit, or do I need to specify every keyword?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is legit.
return the result of reifying the "normal" keyword. | ||
2. If the value is a keyword from <<content-distribution>>, | ||
return the result of reifying the keyword value. | ||
3. Otherwise, the value is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting case with like <<baseline-position>>
, which can be 'baseline', 'first baseline', 'last baseline'. We can either reify 'baseline' as keyword and the others as unsupported, or treat all three as unsupported in case we promote <<baseline-position>>
to its own value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should reify baseline
and first baseline
both to the single keyword baseline
, and treat last baseline
as unsupported.
Same for <content-position>
: reify if there's no <overflow-position>
, unsupported otherwise.
@@ -3574,6 +3574,11 @@ which will be filled in with more detail as we go. | |||
|
|||
: <a>align-content</a> | |||
:: | |||
1. If the specified or computed value is the ''normal'' keyword, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on the property. align-content has the same behavior in specified and computed, so we can combine them.
@@ -3574,6 +3574,11 @@ which will be filled in with more detail as we go. | |||
|
|||
: <a>align-content</a> | |||
:: | |||
1. If the specified or computed value is the ''normal'' keyword, | |||
return the result of reifying the "normal" keyword. | |||
2. If the value is a keyword from <<content-distribution>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is legit.
return the result of reifying the "normal" keyword. | ||
2. If the value is a keyword from <<content-distribution>>, | ||
return the result of reifying the keyword value. | ||
3. Otherwise, the value is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should reify baseline
and first baseline
both to the single keyword baseline
, and treat last baseline
as unsupported.
Same for <content-position>
: reify if there's no <overflow-position>
, unsupported otherwise.
1. If the specified or computed value is the ''auto'' keyword, | ||
return the result of reifying the "auto" keyword. | ||
2. If the specified or computed value is of type <<length>>, | ||
return the result of reifying the <<length>> value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to link to the algo defining this (reify a numeric value). Can combine this with the next step, since lengths and %s use the same algo.
Still drafting this up to get a feel for this, @tabatkins PTAL?