Skip to content

Add a few examples to the reification table #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darrnshn wants to merge 1 commit into from
Closed

Add a few examples to the reification table #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Drafting reify table
  • Loading branch information
@darrnshn
darrnshn committed Feb 22, 2018
commit 32a63b6c1300b99127d3a324c53cf3f0309214ca
10 changes: 10 additions & 0 deletions css-typed-om/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3574,6 +3574,11 @@ which will be filled in with more detail as we go.

: <a>align-content</a>
::
1. If the specified or computed value is the ''normal'' keyword,
Copy link
Copy Markdown
Collaborator Author

@darrnshn darrnshn Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can either do this, or have separate tables for specified vs computed (will have duplications)?

Copy link
Copy Markdown
Member

@tabatkins tabatkins Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on the property. align-content has the same behavior in specified and computed, so we can combine them.

return the result of reifying the "normal" keyword.
2. If the value is a keyword from <<content-distribution>>,
Copy link
Copy Markdown
Collaborator Author

@darrnshn darrnshn Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this legit, or do I need to specify every keyword?

Copy link
Copy Markdown
Member

@tabatkins tabatkins Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is legit.

return the result of reifying the keyword value.
3. Otherwise, the value is not supported.
Copy link
Copy Markdown
Collaborator Author

@darrnshn darrnshn Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting case with like <<baseline-position>>, which can be 'baseline', 'first baseline', 'last baseline'. We can either reify 'baseline' as keyword and the others as unsupported, or treat all three as unsupported in case we promote <<baseline-position>> to its own value?

Copy link
Copy Markdown
Member

@tabatkins tabatkins Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should reify baseline and first baseline both to the single keyword baseline, and treat last baseline as unsupported.

Same for <content-position>: reify if there's no <overflow-position>, unsupported otherwise.


: <a>align-items</a>
::
Expand Down Expand Up @@ -4801,6 +4806,11 @@ which will be filled in with more detail as we go.

: <a>top</a>
::
1. If the specified or computed value is the ''auto'' keyword,
return the result of reifying the "auto" keyword.
2. If the specified or computed value is of type <<length>>,
return the result of reifying the <<length>> value.
Copy link
Copy Markdown
Member

@tabatkins tabatkins Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to link to the algo defining this (reify a numeric value). Can combine this with the next step, since lengths and %s use the same algo.

3. Otherwise, return the result of reifying the <<percentage>> value.

: <a>transform-style</a>
::
Expand Down