CSSUrl, remove quotes from the URL kept in .value #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
CSSUrl.value
was stored verbatim, including any quotes around the actual value inurl( ... )
.As
.value
is also used ingetURL()
, the resulting resolved URL included those quotes, which is wrong.Example:
With a base of
http://www.example.org
, the result fromgetURL()
washttp://www.example.org/"file.png"
.This pull request modifies
CSSUrl
to remove balanced quotes from the input value before it is stored.Admittedly, it has the side effect of removing the quotes also from the output of
toString()
, but they are optional and not needed anyways.