Skip to content

[css-text] Clarify importance of writing system as well as language for lang-specific effects #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fantasai opened this issue Nov 29, 2017 · 7 comments · Fixed by #3202
Closed
Assignees
Labels
css-text-3 Current Work i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. Tested Memory aid - issue has WPT tests Tracked in DoC

Comments

@fantasai
Copy link
Collaborator

https://www.w3.org/TR/css-text-3/#languages notes that typographic effects vary by language but should also mention writing system, and should give examples like ja-latn to emphasize that UAs need to detect script tags. See https://twitter.com/little_potato/status/935608512297820160

@fantasai fantasai added css-text-3 Current Work i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. labels Nov 29, 2017
@frivoal frivoal self-assigned this Oct 3, 2018
@frivoal
Copy link
Collaborator

frivoal commented Oct 4, 2018

@fantasai I wonder if this edit is actually sufficient. Shouldn't we also change bits of text like that in the definition of the line-break property, which say things like "do FOOBAR if the content language is Chinese or Japanese", and instead make them say "do FOOBAR if the writing system is Chinese or Japanese", liking to the text that c983ca6 added to point out that the writing system should be assumed to be that of the content language, unless the author has said otherwise?

If we don't do that, it seems to be that the text you've added, while a great explanation of the situation, isn't actually invoked properly from the rest of the spec.

@frivoal frivoal reopened this Oct 4, 2018
@frivoal
Copy link
Collaborator

frivoal commented Oct 4, 2018

Reopening, so that the above comment doesn't get lost. We can close again if there's nothing to be done, but I'd like to make sure.

@frivoal
Copy link
Collaborator

frivoal commented Oct 9, 2018

But can we actually say "if the writing system is Chinese"? Chinese isn't a writing system, so it seems we should we instead say something like "if the writing system is one of Hans / Hant / Hani / Hanb, or the language is Chinese and the writing system is unspecified". It would be nice if we could drop the second part of the sentence, but it's not clear to me that the mapping from languages to default writing-system for that language is fully defined, and if it isn't, then we need that second clause.

@frivoal
Copy link
Collaborator

frivoal commented Oct 9, 2018

Then again, the above introduces a direct dependency from css to iso15924 writing system tags, instead of leaving the specific way to encode these to the document language. So maybe we should speak of "the Chinese writing system", rather than "one of Hans / Hant / Hani / Hanb"…

@acli
Copy link

acli commented Oct 9, 2018

Since I was the one making the original complaint, I should first apologize for not joining in the discussion, but I think I need to make it clear that my issue was not specific to the Chinese writing system. I did observe the problem while marking up Chinese, but I can’t see how this isn’t going to affect other languages that can be written in multiple scripts (basically anything that’s not written in the Latin alphabet).

I just cobbled up a minimal test:

<!doctype html>
<html lang=en>
<head>
<meta charset=utf-8>
<title>Test</title>
</head>
<body>
<p>
This is a sentence with a Chinese word, <span lang=zh-yue-latn>ping4 on1</span>;
an Arabic word, <span lang=ar-latn>salaam</span>;
and a Hebrew word, <span lang=he-latn>shalom</span>.
</body>
</html>

I have not tried overriding any styling yet, but with default styling all the three non-English words are being displayed using a different font (on Firefox Nightly 64.0a1) even though they are all “latn”. This doesn’t look like something specific to the Chinese writing system to me.

@frivoal
Copy link
Collaborator

frivoal commented Oct 9, 2018

Alright, I've made a pull request that attempt to deal with this. It's quite possible I didn't get it write on the first attempt, but it's a start.

@fantasai, feedback very much welcome.

@frivoal
Copy link
Collaborator

frivoal commented Oct 9, 2018

Made some tentative tests to go along with that spec pull request: web-platform-tests/wpt#13430

frivoal added a commit to frivoal/wpt that referenced this issue Oct 9, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 20, 2018
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <git@florian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430
jankeromnes pushed a commit to jankeromnes/gecko that referenced this issue Nov 21, 2018
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <git@florian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 21, 2018
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <git@florian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430
jankeromnes pushed a commit to jankeromnes/gecko that referenced this issue Nov 22, 2018
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <git@florian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430
@frivoal frivoal added the Tested Memory aid - issue has WPT tests label Apr 25, 2019
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <gitflorian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430

UltraBlame original commit: f3cb0265f0c1de2b76f36205c6735e5203dd7a67
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <gitflorian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430

UltraBlame original commit: 2cf194f546b2f3818e7f79b4e13bb0cc4e5f37cc
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <gitflorian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430

UltraBlame original commit: f3cb0265f0c1de2b76f36205c6735e5203dd7a67
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <gitflorian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430

UltraBlame original commit: 2cf194f546b2f3818e7f79b4e13bb0cc4e5f37cc
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <gitflorian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430

UltraBlame original commit: f3cb0265f0c1de2b76f36205c6735e5203dd7a67
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…stem dependent rules, a=testonly

Automatic update from web-platform-tests[css-text][css-fonts] Testing writing system dependent rules

Related to w3c/csswg-drafts#2015

--
fix typo

Co-Authored-By: frivoal <gitflorian.rivoal.net>
--
Merge pull request #13430 from frivoal/writing-system

[css-text][css-fonts] Testing writing system dependent rules
--

wpt-commits: 60e792e88bf7e2839b584354b128600bb89a7e8f, 643c8394abb53fbca39590728bc30ad96b1feb6c, 9b65752bd8f279c76532401268f06250ac5d479c
wpt-pr: 13430

UltraBlame original commit: 2cf194f546b2f3818e7f79b4e13bb0cc4e5f37cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-text-3 Current Work i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. Tested Memory aid - issue has WPT tests Tracked in DoC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants