Skip to content

[css-text-3] Disentangle content language and writing system #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2018
Merged

[css-text-3] Disentangle content language and writing system #3202

merged 2 commits into from
Nov 15, 2018

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Oct 9, 2018

Closes #2015

@frivoal frivoal added css-fonts-4 Current Work css-text-3 Current Work labels Oct 9, 2018
@frivoal frivoal self-assigned this Oct 9, 2018
@frivoal frivoal mentioned this pull request Oct 9, 2018
Closed
@frivoal frivoal mentioned this pull request Nov 13, 2018
Merged
svgeesus
svgeesus approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great to me. Happy to approve for fonts 4, maybe someone else should also approve for text-3 (but the changes look good, and the clarification on normative appendix is very welcome)

@frivoal
Copy link
Collaborator Author

frivoal commented Nov 14, 2018

Thanks for checking in on the fonts part.

@fantasai has taken a first quick look at the css-text part and found it generally satisfactory, but was planning to do a more careful second pass before merging, just to be sure.

@frivoal frivoal merged commit 1d4b0a1 into w3c:master Nov 15, 2018
@frivoal frivoal deleted the writing-system branch November 15, 2018 07:04
@frivoal
Copy link
Collaborator Author

frivoal commented Nov 15, 2018

Got a review from fantasai suggesting minor tweaks, which I have applied, so I merged.

@frivoal frivoal added the Tested Memory aid - issue has WPT tests label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svgeesus svgeesus svgeesus approved these changes

@fantasai fantasai Awaiting requested review from fantasai

@litherum litherum Awaiting requested review from litherum

Assignees

@frivoal frivoal

Labels
css-fonts-4 Current Work css-text-3 Current Work Tested Memory aid - issue has WPT tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-text] Clarify importance of writing system as well as language for lang-specific effects
2 participants
@frivoal @svgeesus