Skip to content

[css-fonts-3] Typo in onload eventHandler #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pyoor opened this issue Jan 25, 2019 · 2 comments · Fixed by #3558
Closed

[css-fonts-3] Typo in onload eventHandler #3553

pyoor opened this issue Jan 25, 2019 · 2 comments · Fixed by #3558
Assignees
@svgeesus
Labels
Closed Accepted as Editorial css-fonts-3

Comments

@pyoor
Copy link

pyoor commented Jan 25, 2019

The following pages include an encoded '<' character in the onload eventHandler.

window.onload = function () {
  if (!("devicePixelRatio" in window && window.devicePixelRatio > 1)) return;
  var i, hiresElements = document.getElementsByClassName("hires");
  for (i = 0; i &lt; hiresElements.length; i++) {
    var h = hiresElements[i];
    if (h.tagName != "IMG") continue;
    var src = h.getAttribute("src");
    var src2x = src.replace(/\.\w+$/, function(m) { return "@2x" + m; });
    h.src = src2x;
  }
}

csswg-drafts/css-fonts-3/Overview.html

Line 6417 in 40eeef5

for (i = 0; i &lt; hiresElements.length; i++) {

csswg-drafts/css-fonts-3/Fonts.html

Line 6423 in 40eeef5

for (i = 0; i &lt; hiresElements.length; i++) {

ewilligers pushed a commit to ewilligers/csswg-drafts that referenced this issue Jan 25, 2019
@ericwilligers
[css-fonts-3] Fix type on onload eventHandler
03bfdb4 
resolves w3c#3553
@ewilligers ewilligers mentioned this issue Jan 26, 2019
Merged
@svgeesus svgeesus self-assigned this Jan 28, 2019
@svgeesus svgeesus reopened this May 19, 2019
@svgeesus
Copy link
Contributor

Re-opening until the same edits are made to the errata.

@svgeesus
Copy link
Contributor

Errata fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svgeesus svgeesus

Labels
Closed Accepted as Editorial css-fonts-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-fonts-3] Fix type on onload eventHandler ewilligers/csswg-drafts
3 participants
@fantasai @pyoor @svgeesus