[css-fonts-3] Fix type on onload eventHandler #3558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ericwilligers thanks for this. Fonts 3 (and Color 3) use an old, unmaintained preprocessor and build Overview.html from Overview.html.src. But that tool is now broken and the published (W3C Recommendation) version of Fonts 3 has a bunch of edits on the post-processed output. I need to first land the edited (Rec) version back as a new ED. I also plan to delete or archive the .src file (and the redundant Fonts.html) at that time. Then I can apply your patch on top of it. I will also need to generate an erratum for the Rec, also based on your patch. Which is by way of explaining the |
svgeesus
reviewed
Jan 28, 2019
|
Merged, also now listed in the Fonts 3 errata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3553