-
Notifications
You must be signed in to change notification settings - Fork 710
[scroll-animations-1] Where is the range of threshold values checked? #5203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That said, I'm not sure if we want to enforce that range or not. Maybe -0.1 is a useful measure? If so, we should probably say that. |
Having the ability to — for example — set A from-offset of Also see #6068, where taking Both these use-cases could be allowed I guess:
|
I'd prefer it to not clamp to a "valid range" when that "valid range" is entirely arbitrary and restricts design possibilities. |
I suspect this may still be applicable for View Timelines, i.e. a desire to be able to extend the effective element size for the purpose of its fit to the view timeline. In scroll snap terms this would be scroll-margin. Note that scroll-margin does not seem to accept a percentage currently so |
@flackr Isn't this exactly what |
Right, the gap between The percentages we have in the spec don't seem to have precise limits so I'd propose we close this one. |
@birtles @bramus Can you confirm if you're ok to close based on @flackr's comment above? |
It looks like the |
The Closing issue. Adjusting labels. |
For element-based offsets, the
threshold
member has the following description:But we don't seem to validate anywhere that that is the case. Should be check it in the constructor for
ScrollTimeline
?The text was updated successfully, but these errors were encountered: