-
Notifications
You must be signed in to change notification settings - Fork 708
[scroll-animations-1] Clarify that progress percentages must be between 0% and 100% #8552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do we have to restrict it? Isn't something like |
If there's no need to limit the accepted range, then please. Just to be sure: this would also play nice with negative offsets? |
Yes, negative offsets calculate to their overall relative percentage. The only weird case we have right now is that view timelines do not start before the cover period so if you try to go less than 0% or more than 100% of the cover range it will interpolate from that position but not be active until you're in the cover range. I think this is probably fine, though I have often wondered whether we should make view timelines active for the entire scroll range so that cases like this would be supported. |
I am not sure if you are only discussing the
https://drafts.csswg.org/css-animations-1/#keyframes Edit: nevermind (answer is no and the single |
Merged in @bramus's PR to clarify that raw percentage @Keyframes are invalid. Keeping the issue open in case @flackr wants to follow up on any of his comments above. |
This all looks good to me. |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> fantasai: we're just clarifying we can do 'contain -20%' and it's valid<TabAtkins> fantasai: Currently spec allows it <bramus> +1 <TabAtkins> flackr: I support, these dynamic ranges can also compute outside their 0-100 range <TabAtkins> astearns: objections? <TabAtkins> RESOLVED: %s outside the 0-100 range are valid in progress percentages |
While checking #5203 (comment), I noticed the scroll-animations-1 spec doesn’t mention that the percentages for the timeline ranges must be between 0% and 100%.
Furthermore the original
<keyframe-selector>
definition from css-animations-1 seems to have inadvertently been relaxed as the allowed range for<percentage>
is no longer mentioned.css-animations-1:
scroll-animations-1:
I think we should explicitly mention the allowed range.
The text was updated successfully, but these errors were encountered: