Skip to content

[css-highlight-api-1] Example 4 is outdated and has some inconsistencies #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ffiori opened this issue May 31, 2021 · 0 comments
Closed

[css-highlight-api-1] Example 4 is outdated and has some inconsistencies #6333

ffiori opened this issue May 31, 2021 · 0 comments
Labels
css-highlight-api-1

Comments

@ffiori
Copy link
Member

ffiori commented May 31, 2021 •
edited
Loading

This issue is related to Example 4 of this draft: https://drafts.csswg.org/css-highlight-api-1

  • There are two calls to CSS.highlights.add() which correspond to the version of a setlike HighlightRegistry. This no longer works in this way since it's been agreed to make it maplike here.
  • In the style section, the rules are of the form of p::highlight{} but there's no <p> in <body>, so no custom style will be used for painting.
  • In the explanation, there are references to rg1 and rg2 which aren't defined in the code.
@ffiori ffiori mentioned this issue May 31, 2021
Merged
@ffiori ffiori changed the title [css-highlight-api-1] Example 4 should be updated to comply with the newest specifications [css-highlight-api-1] Example 4 is outdated and have some inconsistencies Jun 1, 2021
@ffiori ffiori changed the title [css-highlight-api-1] Example 4 is outdated and have some inconsistencies [css-highlight-api-1] Example 4 is outdated and has some inconsistencies Jun 1, 2021
@sanketj sanketj closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-highlight-api-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanketj @ffiori