[css-highlight-api-1] Make HighlightRegistry maplike #6198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeaVerou
reviewed
Apr 10, 2021
LeaVerou
reviewed
Apr 10, 2021
LeaVerou
reviewed
Apr 13, 2021
LeaVerou
approved these changes
Apr 13, 2021
Member
LeaVerou
left a comment
There was a problem hiding this comment.
LGTM. See the one minor comment I left.
…property from Highlight.
…hlight names that are CSS identifiers for easier styling via CSS.
…ame to style a highlight and add an example showcasing why using multiple names is problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[css-highlight-api-1] Make HighlightRegistry maplike and remove name property from Highlight.
[css-highlight-api-1] Add note recommending authors to use custom highlight names that are CSS identifiers for easier styling via CSS.
[css-highlight-api-1] Add note recommending authors to only use one name to style a highlight and add an example showcasing why using multiple names is problematic.
Resolves #5910