Skip to content

[css-highlight-api-1] Update examples #6332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2021
Merged

Conversation

ffiori
Copy link
Member

@ffiori ffiori commented May 31, 2021

[css-highlight-api-1] Update examples

Resolves issue #6331:

  • Add 'div' variable definition in Example 2.
  • Indent Example 1 and 2 like the others (one tab for contents of <style> and <script>).

Resolves issue #6333:

  • Define Highlights h1 and h2 in Example 4, update the explanation accordingly.
  • Change CSS.highlights.add() into CSS.highlights.set() in Example 4.
  • Change style rules from p::highlight into ::highlight.

@ffiori
Copy link
Member Author

ffiori commented May 31, 2021

@sanketj

@sanketj sanketj merged commit a815bf7 into w3c:main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants