Skip to content

[cssom-view] Merge visualViewport into working group #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bokand opened this issue Jun 2, 2021 · 3 comments · Fixed by #7316
Closed

[cssom-view] Merge visualViewport into working group #6339

bokand opened this issue Jun 2, 2021 · 3 comments · Fixed by #7316

Comments

@bokand
Copy link
Contributor

bokand commented Jun 2, 2021

Hi all,

The visualViewport proposal is now implemented and shipped in all of Blink, WebKit, and Gecko. I think it'd make sense to put it on a standards track at this point.

I imagine CSSOM-View is probably the right place but don't have a strong opinion.

WDYT?

Spec
Explainer

@css-meeting-bot
Copy link
Member

css-meeting-bot commented Jun 16, 2021

The CSS Working Group just discussed cssom-view, and agreed to the following:

  • RESOLVED: Incorporate visualViewport into cssom-view and add bokand as editor
The full IRC log of that discussion <fantasai> Topic: cssom-view
<fantasai> github: https://github.com//issues/6339
<TabAtkins> https://wicg.github.io/visual-viewport/index.html
<fantasai> TabAtkins: Visual Viewport spec that allows getting bounds of visual viewport in JS
<fantasai> TabAtkins: has been implemented cross-browser for awhile
<fantasai> TabAtkins: probably should be on standards-track
<fantasai> TabAtkins: suggestion is to put into cssom-view
<fremy> LGTM
<astearns> ack fantasai
<TabAtkins> fantasai: Who's the editor?
<fremy> fantasai: who is gonna be editor?
<fantasai> TabAtkins: bokan is editor of visual viewport spec... and is a member of CSSWG
<fantasai> TabAtkins: could just add him
<fantasai> smfr: Emilio and I are editors of CSSOM-view, and would appreciate editorial help
<fremy> fantasai: sounds like a good idea to have one more person on this
<fantasai> TabAtkins: chrishtr, can we volunteer bokand?
<fantasai> chrishtr: We can try, and if he's busy, we'll find somone else on our staff
<fantasai> astearns: so propose to incorporate visualViewport into cssom-view and add bokand as editor
<fantasai> RESOLVED: Incorporate visualViewport into cssom-view and add bokand as editor
<fremy> welcome to the css family, new spec :)
<fremy> fantasai: one more comment
<fremy> fantasai: it's a bit weird how things happened here
<fremy> fantasai: we are not doing standardization, we are doing documentation
<fremy> fantasai: I don't find this workflow appropriate
<fremy> fantasai: so I agree to do it here, but it's worth nothing I think it is not a good workflow
<fantasai> fantasai: It's too late to make any changes now, it's not exactly accurate to say you're shifting it to the CSSWG for the "standardization" process
<fremy> astearns: I agree
<fremy> astearns: that said, it happens, and we can't change it
<fremy> astearns: and documentation is still good
<fremy> TabAtkins: also, it shipped in multiple browsers
<fremy> TabAtkins: discussion happened, in another venue
<fremy> TabAtkins: but patent protection was not part of this, and this is not ideal

@theres-waldo
Copy link
Contributor

fantasai: one more comment
fantasai: it's a bit weird how things happened here
fantasai: we are not doing standardization, we are doing documentation
fantasai: I don't find this workflow appropriate
fantasai: so I agree to do it here, but it's worth nothing I think it is not a good workflow
fantasai: It's too late to make any changes now, it's not exactly accurate to say you're shifting it to the CSSWG for the "standardization" process

Hi, I'm one of the Firefox engineers who worked on this feature.

For my future reference, could you clarify what, if anything, we should have done differently? Should we have kept the feature disabled by default until the W3C process completes? Should Chrome have done the same?

Thanks, and my apologies if we didn't follow the process correctly.

@tabatkins
Copy link
Member

You were fine. The WICG document was produced with significant cross-browser discussion and agreement; that's the important part. Checking in with the CSSWG when producing a document intended to eventually be absorbed by the WG is good practice, to make sure there's wider review, but looking over your issues list I see a lot of familiar names, so I'm not too concerned about narrow review. (This is especially true when doing new properties or values, as there's significant expertise in the WG that might not be shared by experienced engineers ouside the WG, but for a straightforward JS API like this it's much less of an issue.)

The only thing that might have been done slightly better is that it looks like this was shipped before any patent agreements covered it; that comes for free when publishing a Rec-track document in a WG, but has to be done manually in a CG with a separate agreement. (Maybe y'all did go thru that process; I can't tell without digging into your archives.) That's just exposing browsers to some potential risk, which is mitigated by having it published thru a WG with wide membership like ours.

bokand added a commit that referenced this issue Jul 7, 2022
* Introduce VisualViewport into cssom-view-1
tidoust added a commit to w3c/browser-specs that referenced this issue Jul 8, 2022
The proposed Visual Viewport API has been merged into CSSOM View:
w3c/csswg-drafts#6339
tidoust added a commit to w3c/browser-specs that referenced this issue Jul 8, 2022
The proposed Visual Viewport API has been merged into CSSOM View:
w3c/csswg-drafts#6339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants