[cssom-view-1] Introduce VisualViewport API #6339 #7316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I was added to csswg so I'm now able to add reviewers, PTAL, thanks! |
emilio
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Really sorry for the massive lag here (was on PTO last week until yesterday and this was on the long queue of things to catch up). Thanks for the ping. Looks good, just some minor questions.
I suppose you have permission to merge, otherwise lmk and I can merge for you. Thanks!
|
Thanks for the review! (No worries - I assumed folks were on vacation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[cssom-view-1] Introduce VisualViewport API #6339
This PR merges the visual-viewport API from the WICG spec into cssom-view-1 as agreed in #6339.
This omits the experimental
segmentsextension in the WICG repo as well as the broader non-normative discussion. Some wording and flow was reworked for consistency with the cssom-view-1 spec.Fixes #6339