-
Notifications
You must be signed in to change notification settings - Fork 711
[css-fonts-4] absolute-color in override-colors unspecified #7010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, IIRC the change that added that grammar also modified the color spec. |
Bikeshed reports, on building CSS Fonts 4
probably because CSS Color 4 has <pre class='prod'>
<color> = <<absolute-color-base>> | currentcolor | <<system-color>> | <<device-cmyk()>>
<dfn><absolute-color-base></dfn> = <<hex-color>> | <<named-color>> | transparent |
<<rgb()>> | <<rgba()>> | <<hsl()>> | <<hsla()>> | <<hwb()>> |
<<lab()>> | <<lch()>> |
<<oklab()>> | <<oklch()>> |
<<color()>>
</pre> So, the fix is to change Fonts 4 to use the actual exported term :) |
Oh I just noticed
If that is correct, I need to make a different edit. Is currentColor to be included? |
I intentionally omitted |
Okay in that case, what we currently have is correct |
Thanks for fixing the reference.
But if it was |
Ah, I see. At the time of c790f28 So yes this needs a further edit to add back |
I am in favour of excluding From an implementation perspective, I find it difficult to resolve |
Yes, I think we are all agreed that The remaining question is whether to add the device-cmyk back, which I guess we should do. |
Current color excluded from possible values for override-colors: entries, see discussion in w3c#7010
This reverts commit e14ed86. As discussed in #31517 and w3c/csswg-drafts#7010
Current color excluded from possible values for override-colors: entries, see discussion in #7010
This reverts commit e14ed86. As discussed in web-platform-tests#31517 and w3c/csswg-drafts#7010
… in @font-palette-values", a=testonly Automatic update from web-platform-tests Revert "New tets for use of currentColor in @font-palette-values" This reverts commit e14ed8613f431e528b83f074ce37cf6e22dd95b6. As discussed in web-platform-tests/wpt#31517 and w3c/csswg-drafts#7010 -- wpt-commits: 13b16f2df09ae8b579fbf9ebeca5f6153f494d55 wpt-pr: 32812
This reverts commit e14ed86. As discussed in web-platform-tests#31517 and w3c/csswg-drafts#7010
… in @font-palette-values", a=testonly Automatic update from web-platform-tests Revert "New tets for use of currentColor in @font-palette-values" This reverts commit e14ed8613f431e528b83f074ce37cf6e22dd95b6. As discussed in web-platform-tests/wpt#31517 and w3c/csswg-drafts#7010 -- wpt-commits: 13b16f2df09ae8b579fbf9ebeca5f6153f494d55 wpt-pr: 32812
… in @font-palette-values", a=testonly Automatic update from web-platform-tests Revert "New tets for use of currentColor in @font-palette-values" This reverts commit e14ed8613f431e528b83f074ce37cf6e22dd95b6. As discussed in web-platform-tests/wpt#31517 and w3c/csswg-drafts#7010 -- wpt-commits: 13b16f2df09ae8b579fbf9ebeca5f6153f494d55 wpt-pr: 32812
… in @font-palette-values", a=testonly Automatic update from web-platform-tests Revert "New tets for use of currentColor in @font-palette-values" This reverts commit e14ed8613f431e528b83f074ce37cf6e22dd95b6. As discussed in web-platform-tests/wpt#31517 and w3c/csswg-drafts#7010 -- wpt-commits: 13b16f2df09ae8b579fbf9ebeca5f6153f494d55 wpt-pr: 32812
@drott see |
says:
But I can't find a reference for
absolute-color
. Has the color spec changed after this? I assume the intention is to allow<<absolute-color-base>> | currentcolor
but not| <<system-color>> | <<device-cmyk()>>
.CC @litherum @svgeesus
Edit: See below for clarifications re
currentcolor
.The text was updated successfully, but these errors were encountered: