Skip to content

[css-fonts] Context for resolving override-color colors #6681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2021
Merged

[css-fonts] Context for resolving override-color colors #6681

merged 2 commits into from
Sep 28, 2021

Conversation

@litherum
Copy link
Contributor

@litherum litherum commented Sep 24, 2021

Fixes #6680.

@litherum litherum requested a review from svgeesus September 24, 2021 06:39
@litherum litherum mentioned this pull request Sep 24, 2021
Closed
@litherum litherum force-pushed the font-palette-absolute-color branch from ebcc6a6 to 733d3dc Compare September 24, 2021 06:40
@litherum litherum force-pushed the font-palette-absolute-color branch from 733d3dc to c790f28 Compare September 24, 2021 06:41
svgeesus
svgeesus approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this solves the issue.

It also reminds me to raise an issue, do we really need the fallback on device-cmyk()? But that doesn't block this PR, it just might make some of it go away again.

@svgeesus svgeesus merged commit da9c67d into w3c:main Sep 28, 2021
@litherum litherum deleted the font-palette-absolute-color branch October 13, 2021 00:30
@drott drott mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svgeesus svgeesus svgeesus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[css-fonts] [palettes] Context for resolving override-color colors

2 participants

@litherum @svgeesus