Skip to content

Pluralize feature-* to features-*? #7663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
svgeesus opened this issue Aug 30, 2022 · 6 comments
Closed

Pluralize feature-* to features-*? #7663

svgeesus opened this issue Aug 30, 2022 · 6 comments
Labels
css-conditional-5 Current Work

Comments

@svgeesus
Copy link
Contributor

Originally raised by @jfkthame :

(3) A really minor issue, but I have found myself repeatedly writing things like @supports font-tech(features-opentype), and not getting the expected result because the correct keyword is feature-opentype (singular). To my mind, the feature-* keywords would read more naturally in the plural form (similarly to font-tech(variations)). Should we change them to plural, here and in CSS Fonts, before this is widely implemented and webcompat becomes a constraint?
@svgeesus svgeesus added the css-conditional-5 Current Work label Aug 30, 2022
@svgeesus svgeesus mentioned this issue Aug 30, 2022
Open
@drott
Copy link
Collaborator

drott commented Aug 30, 2022

Yes, I support this. I would even hope we can consider this a minor editing change and proceed with it. @litherum @jfkthame ?

@svgeesus
Copy link
Contributor Author

I think it reads better as the plural, too

@svgeesus
Copy link
Contributor Author

svgeesus commented Aug 30, 2022 •
edited
Loading

This change would also affect CSS Fonts 4 and 5 because obviously we would want consistency between Conditional and Fonts specs..

@svgeesus
Copy link
Contributor Author

Ok I am going to call this, because in 11.1. Font tech it says (note the plural)

The features-opentype, features-aat and features-graphite techs refer to support for font features, commonly implemented in [OPENTYPE] with the GSUB and the GPOS tables, as well as in [AAT-FEATURES] using the morx and kerx tables and [GRAPHITE] with the Silf, Glat , Gloc , Feat and Sill tables as documented in the Graphite Table Format.

@svgeesus
Copy link
Contributor Author

it is already plural in Conditional 5

@drott
Copy link
Collaborator

drott commented Aug 30, 2022

Thanks, Chris.

Closed
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Aug 30, 2022
@drott @chromium-wpt-export-bot
Support tech() function parsing in @font-face src: descriptor
f8de986 
Add support for parsing and interpreting the tech() function in the src:
descriptor of @font-face. Only add font faces with supported
technologies to the list. Adapt src: line understanding to CSS Fonts
Level 4.

Rename values in test to plural forms, as just completed as a spec
change in [2].

[1] https://drafts.csswg.org/css-fonts-4/#font-face-src-parsing
[2] w3c/csswg-drafts#7663

Bug: 1216460
Change-Id: I6abb5b0bf3300b9abd855381ce0c6bad518949a6
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Aug 30, 2022
@drott @chromium-wpt-export-bot
Support tech() function parsing in @font-face src: descriptor
dca7be7 
Add support for parsing and interpreting the tech() function in the src:
descriptor of @font-face. Only add font faces with supported
technologies to the list. Adapt src: line understanding to CSS Fonts
Level 4.

Rename values in test to plural forms, as just completed as a spec
change in [2].

[1] https://drafts.csswg.org/css-fonts-4/#font-face-src-parsing
[2] w3c/csswg-drafts#7663

Bug: 1216460
Change-Id: I6abb5b0bf3300b9abd855381ce0c6bad518949a6
aarongable pushed a commit to chromium/chromium that referenced this issue Aug 31, 2022
@drott
Support tech() function parsing in @font-face src: descriptor
83e2f6f 
Add support for parsing and interpreting the tech() function in the src:
descriptor of @font-face. Only add font faces with supported
technologies to the list. Adapt src: line understanding to CSS Fonts
Level 4.

Rename values in test to plural forms, as just completed as a spec
change in [2].

[1] https://drafts.csswg.org/css-fonts-4/#font-face-src-parsing
[2] w3c/csswg-drafts#7663

Bug: 1216460
Change-Id: I6abb5b0bf3300b9abd855381ce0c6bad518949a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3856267
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1041440}
yisibl added a commit to yisibl/lightningcss that referenced this issue Sep 5, 2022
@yisibl
fix: match the spec so that feature-* in tech() becomes plural
ae8d854 
Spec changed in: w3c/csswg-drafts#7663 (comment)
Chrome CL: https://chromium-review.googlesource.com/c/chromium/src/+/3856267
@yisibl yisibl mentioned this issue Sep 5, 2022
Merged
devongovett pushed a commit to parcel-bundler/lightningcss that referenced this issue Sep 7, 2022
@yisibl
fix: match the spec so that feature-* in tech() becomes plural (#270)
4485c3d 
Spec changed in: w3c/csswg-drafts#7663 (comment)
Chrome CL: https://chromium-review.googlesource.com/c/chromium/src/+/3856267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-conditional-5 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drott @svgeesus