[CONTRIBUTING.md] Clarify that PRs should originate from your own fork #10009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was much more of an issue when the GitHub to Mercurial two-way bridge was still an important part of some people's workflow because any branch here would break things. AFAIK that is no longer the case. |
svgeesus
approved these changes
Feb 28, 2024
frivoal
approved these changes
Feb 28, 2024
|
Yeah, maintaining branches either here or in your personal fork are both fine. The main benefit of keeping them in your own fork is it keeps our list of branches smaller, so you don't have as many things cluttering up the branches list. (In other words, I'm fine with keeping this advice here.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor update to clarify that PRs should originate from your own fork. This is something I had to find out when filing one of my first PRs – I had created a branch in the
w3c/csswg-draftsrepo, upon which I was told that this isn’t how things are done here.