[Contributing.md] Suggestion to improve the contribution best practices #9928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantasai
reviewed
Feb 9, 2024
fantasai
reviewed
Feb 9, 2024
fantasai
reviewed
Feb 9, 2024
Addressing @fantasai's feedback and removing double-whitespace-after-period.
frivoal
approved these changes
Feb 12, 2024
|
As this isn't a spec, unfortunately these guidelines aren't quite applicable (since there's no Editor :P ). As I note a couple of approvals and a thumbs-up from one of the chairs, I'll leave it to you all to decide when it's appropriate to merge once @fantasai has given it a re-review. |
tantek
approved these changes
Feb 12, 2024
|
We will announce this update on the Feb 28 call and can take further improvements |
|
To those following: filed a small PR to clarify where PRs should originate from: #10009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merely a suggestion to improve the contribution best practices to reflect (what I think is) the actual status quo.
This is based on an attempt to figure out how we could have avoided some incidents that ruffled a few feathers, by being clearer about expectations; I'd welcome feedback about whether this is useful or if it could be improved in some other way.