Skip to content

[css-view-transitions-2] Clarify a few nesting details #10964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noamr merged 4 commits into from
Oct 14, 2024
Merged

[css-view-transitions-2] Clarify a few nesting details #10964

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf6c601
[css-view-transitions-2] Clarify a few nesting details
noamr Sep 27, 2024
e415d44
Simplify tree-scope matching
noamr Oct 1, 2024
a92961f
Make everything algorithmic
noamr Oct 8, 2024
ccfd8ef
Update Overview.bs
noamr Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[css-view-transitions-2] Clarify a few nesting details 
- view-transition-group is tree-scoped
- nearest/custom-ident act like contain

Closes #10780
Closes #10633
  • Loading branch information
@noamr
noamr committed Oct 2, 2024
commit cf6c601ae5c02b30a6615f5612dab43bf89957fa
20 changes: 10 additions & 10 deletions css-view-transitions-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,20 +886,20 @@ and by applying ''view-transition-group'' to the internal element referencing th

When the [=computed value=] of 'view-transition-name' for an element is ''view-transition-name/none'', its 'view-transition-group' [=used value=] is always resolved to ''view-transition-name/none'' as well.

The <dfn>relevant tree</dfn> for the 'view-transition-group' property is the [=tree=] that includes the element in which the property itself is declared.
Copy link
Member

@khushalsagar khushalsagar Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is trying to capture the tree scope for the computed value right? Would it be enough to say that the used value for group is "normal" if it doesn't match view transition name's scope. Because the group only applies if the name does and we have checks to only apply the name if the tree scope matches the transition's tree scope.

Copy link
Collaborator Author

@noamr noamr Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


<dl dfn-type=value dfn-for=view-transition-group>
: <dfn>normal</dfn>
:: The [=used value=] is the element's [=nearest containing group name=].

: <dfn>nearest</dfn>
:: The [=used value=] is the 'view-transition-name' [=computed value=] of the nearest ancestor whose 'view-transition-name' [=computed value=] is not ''view-transition-name/none''.

: <dfn>contain</dfn>
:: The [=used value=] is the element's [=nearest containing group name=].
:: The [=used value=] is the element's [=nearest containing group name=] given the [=relevant tree=].

Note: An element with ''view-transition-group/contain'' becomes the [=nearest containing group name=] for its [=tree/descendants=].

Note: Descendant elements are contained within this group by default, as it would be their element's [=nearest containing group name=].
: <dfn>nearest</dfn>
:: The [=used value=] is the 'view-transition-name' [=computed value=] of the nearest [=tree/ancestor=] in the [=relevant tree=] whose 'view-transition-name' [=computed value=] is not ''view-transition-name/none''.

: <dfn><<custom-ident>></dfn>
:: The [=used value=] is the given <<custom-ident>> if the element has an ancestor whose 'view-transition-name' [=computed value=] is that <<custom-ident>>, otherwise the element's [=nearest containing group name=]
:: The [=used value=] is the given <<custom-ident>> if the element has an [=tree/ancestor=] in the [=relevant tree=] whose 'view-transition-name' [=computed value=] is that <<custom-ident>>, otherwise the element's [=nearest containing group name=] given the [=relevant tree=].
</dl>

# Algorithms # {#algorithms}
Expand Down Expand Up @@ -1180,9 +1180,9 @@ When capturing the old or new state for an element, perform the following steps
### Compute the nearest containing 'view-transition-group' ### {#vt-group-nearest-contain}
<div algorithm="nearest containing group name">

To get the <dfn>nearest containing group name</dfn> for an {{Element}} |element|, perform the following steps:
To get the <dfn>nearest containing group name</dfn> for an {{Element}} |element| and a [=tree=] |tree|, perform the following steps:

1. Let |nearestAncestorWithContain| be |element|'s nearest ancestor whose 'view-transition-name' [=computed value=] is not ''view-transition-name/none'' and whose 'view-transition-group' [=computed value=] is ''view-transition-group/contain''.
1. Let |nearestAncestorWithContain| be |element|'s nearest [=tree/ancestor=] in |tree|, whose 'view-transition-name' [=computed value=] is not ''view-transition-name/none'' and whose 'view-transition-group' [=computed value=] is not ''view-transition-group/normal''.
Copy link
Member

@khushalsagar khushalsagar Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to pass tree here? We can ignore the group if its computed value's tree scope doesn't match view-transition-name's tree scope.

Copy link
Collaborator Author

@noamr noamr Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

1. If |nearestAncestorWithContain| is null, return ''view-transition-group/none''.
1. Otherwise, return |nearestAncestorWithContain|'s 'view-transition-name' [=computed value=].
</div>
Expand Down