[css-values-5] Don't use flat tree for tree-counting #9562 #12144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per resolution[1], tree counting functions should not use the flat tree for indexing. Instead use the term 'inclusive siblings' from the DOM spec, which is the same term that :nth-*() selectors use. [1] w3c#9562 (comment)
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 2, 2025
Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1454908}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 2, 2025
Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1454908}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 2, 2025
Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1454908}
tabatkins
reviewed
May 2, 2025
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 12, 2025
…te on the flat tree, Automatic update from web-platform-tests Tree counting functions should not operate on the flat tree Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1454908} -- wpt-commits: 017a682952e4ff1d21db0184cf588ae1496f8d2c wpt-pr: 52304 Differential Revision: https://phabricator.services.mozilla.com/D248798
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 12, 2025
…te on the flat tree, Automatic update from web-platform-tests Tree counting functions should not operate on the flat tree Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1454908} -- wpt-commits: 017a682952e4ff1d21db0184cf588ae1496f8d2c wpt-pr: 52304 Differential Revision: https://phabricator.services.mozilla.com/D248798
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 14, 2025
…te on the flat tree, Automatic update from web-platform-tests Tree counting functions should not operate on the flat tree Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futharkchromium.org> Reviewed-by: Steinar H Gunderson <sessechromium.org> Cr-Commit-Position: refs/heads/main{#1454908} -- wpt-commits: 017a682952e4ff1d21db0184cf588ae1496f8d2c wpt-pr: 52304 Differential Revision: https://phabricator.services.mozilla.com/D248798 UltraBlame original commit: ef6e706d4ad30551a3c195f3642a18ef39287dce
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 14, 2025
…te on the flat tree, Automatic update from web-platform-tests Tree counting functions should not operate on the flat tree Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futharkchromium.org> Reviewed-by: Steinar H Gunderson <sessechromium.org> Cr-Commit-Position: refs/heads/main{#1454908} -- wpt-commits: 017a682952e4ff1d21db0184cf588ae1496f8d2c wpt-pr: 52304 Differential Revision: https://phabricator.services.mozilla.com/D248798 UltraBlame original commit: ef6e706d4ad30551a3c195f3642a18ef39287dce
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 14, 2025
…te on the flat tree, Automatic update from web-platform-tests Tree counting functions should not operate on the flat tree Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futharkchromium.org> Reviewed-by: Steinar H Gunderson <sessechromium.org> Cr-Commit-Position: refs/heads/main{#1454908} -- wpt-commits: 017a682952e4ff1d21db0184cf588ae1496f8d2c wpt-pr: 52304 Differential Revision: https://phabricator.services.mozilla.com/D248798 UltraBlame original commit: ef6e706d4ad30551a3c195f3642a18ef39287dce
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 15, 2025
…te on the flat tree, Automatic update from web-platform-tests Tree counting functions should not operate on the flat tree Per resolution and PR[1] This is basically a revert of [2] and [3]. [1] w3c/csswg-drafts#12144 [2] https://crrev.com/09ec78e0186d6d28678452d305af13ce4cf092dd [3] https://crrev.com/335f039762e05639ba4f0efc00022b36a631e259 Bug: 413015181 Change-Id: I50b38a60745f85eae0346556863def756bd8f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6508508 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1454908} -- wpt-commits: 017a682952e4ff1d21db0184cf588ae1496f8d2c wpt-pr: 52304 Differential Revision: https://phabricator.services.mozilla.com/D248798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per resolution[1], tree counting functions should not use the flat tree for indexing. Instead use the term 'inclusive siblings' from the DOM spec, which is the same term that :nth-*() selectors use.
[1] #9562 (comment)