Skip to content

Conversation

@hayatoito
Copy link
Member

My attempt to fix #159.

@tabatkins , could you review this?

Return the nearest ancestor unclosed node element of the element

"unclosed node element of the element" can be acceptable?

@TakayoshiKochi
Copy link
Member

Hmm, can it be "unclosed element", just use "unclosed" as an adjective?

And in that case we need to add "unclosed element" in the glossary definition in the shadow dom spec as well in addition to "unclosed node"?

@zcorpan
Copy link
Contributor

zcorpan commented Jun 10, 2016

You could do <a lt="unclosed node">unclosed</a> element or some such. Also add [[!DOM]] at the end of the paragraph.

@zcorpan zcorpan changed the title [css-omview] Fix #159. Do not leak a closed node via offsetParent [cssom-view] Fix #159. Do not leak a closed node via offsetParent Jun 10, 2016
@zcorpan
Copy link
Contributor

zcorpan commented Jun 10, 2016

(The commit message should say [cssom-view], but we can fix that when merging.)

@tabatkins
Copy link
Member

@hayatoito Yup, agree with @zcorpan's review. Fix those two nits, and --amend the commit message to use the right tag, and i'll merge.

@hayatoito hayatoito force-pushed the offset-parent-unclosed branch from 97781e3 to ec0bb47 Compare June 13, 2016 06:38
@hayatoito hayatoito force-pushed the offset-parent-unclosed branch from ec0bb47 to 6da67c3 Compare June 13, 2016 06:39
@hayatoito
Copy link
Member Author

hayatoito commented Jun 13, 2016

@zcorpan @tabatkins Thanks! I did amend the commit.

You could do <a lt="unclosed node">unclosed</a> element or some such. Also add [[!DOM]] at the end of the paragraph.

Done.

(The commit message should say [cssom-view], but we can fix that when merging.)

The subject of the commit includeded [cssom-view], I think. I did not change the subject.
Is that okay?

@zcorpan zcorpan merged commit 06fb597 into w3c:master Jun 14, 2016
@zcorpan
Copy link
Contributor

zcorpan commented Jun 14, 2016

Thanks! (It said [css-omview] rather than [cssom-view])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cssom-view] HTMLElement.prototype.offsetParent leaks a node inside a shadow tree

4 participants