[cssom-view] Fix #159 update offsetParent spec for Shadow DOM - #252
Merged
Conversation
Member
Author
|
@zcorpan @tabatkins @hayatoito Could you take a look? |
| * It is <a>the HTML <code>body</code> element</a>. | ||
| * The computed value of the 'position' property of the element is ''static'' and the ancestor is one of the following <a>HTML elements</a>: <code>td</code>, <code>th</code>, or <code>table</code>. | ||
| 1. Return null. | ||
| 1. Let <var>ancestor</var> be the element and repeat these substeps: |
Member
There was a problem hiding this comment.
ancestor should be the parent of the element here.
TakayoshiKochi
force-pushed
the
offsetparent
branch
from
June 29, 2016 07:39
b3a734c to
1a55e1c
Compare
| 1. Return null. | ||
| 1. Let <var>ancestor</var> be the parent of the element and repeat these substeps: | ||
| 1. If <var>ancestor</var> is not an <a lt="unclosed node">unclosed</a> element of the element and its computed value of the 'position' property is ''position/fixed'', terminate this algorithm and return null. | ||
| 1. If <var>ancestor</var> is an <a lt="unclosed node">unclosed</a> element of the element and satisfies at least one of the following is true, terminate this algorithm and return <var>ancestor</var>. |
Contributor
|
LGTM % wording nit |
TakayoshiKochi
force-pushed
the
offsetparent
branch
from
June 29, 2016 10:34
1a55e1c to
2341bdc
Compare
Member
Author
|
@tabatkins could you take a look? |
Member
Author
|
@tabatkins Ping? |
1 similar comment
Member
Author
|
@tabatkins Ping? |
Member
Author
|
@tabatkins Had a nice vacation ;) ? |
Member
|
Hmm, this reads a little weird to me. I'm not certain the first condition can ever be hit - we're walking the ancestor chain of the element, and I think an element's ancestors are always unclosed relative to it. |
Member
Author
|
No, it happens when an element is slotted into a closed shadow tree. <div id="shadow" style="position: relative">
#shadow-root (closed)
<div id="container" style="position: relative">
<slot></slot>
</div>
<div id="X">Hello</div>
</div>
Hmm, I should have used "the parent of the element in the flat tree" for all "the parent of ~" |
TakayoshiKochi
force-pushed
the
offsetparent
branch
from
August 2, 2016 02:33
2341bdc to
0c972e7
Compare
Member
Author
|
@tabatkins Could you take another look? |
| * It is <a>the HTML <code>body</code> element</a>. | ||
| * The computed value of the 'position' property of the element is ''static'' and the ancestor is one of the following <a>HTML elements</a>: <code>td</code>, <code>th</code>, or <code>table</code>. | ||
| 1. Return null. | ||
| 1. Let <var>ancestor</var> be the parent of the element in the flat tree and repeat these substeps: |
Member
|
Okay, final nit, then +1 from me. |
The previous attempt to update offsetParent was incomplete: when the real offsetParent in the closed shadow tree has 'position:fixed', offsetParent should return null, instead of continue searching for unclosed ancestor.
TakayoshiKochi
force-pushed
the
offsetparent
branch
from
August 9, 2016 02:06
0c972e7 to
5589932
Compare
Member
Author
|
Done. Thanks for the review! |
Member
Author
|
@zcorpan could you merge this? |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous attempt to update offsetParent to fix #159 was incomplete:
when the real offsetParent in the closed shadow tree has
'position:fixed', offsetParent should return null, instead
of continue searching for unclosed ancestor.