Line height fixes #1993
Merged
Line height fixes #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes w3c#1797
Includes a "MAY" allowing UAs to use different font metrics for line-height:normal vs other values. This should be clarified later and turned into a MUST one way or the other to make sure all browsers agree, but for now it seems that at least Gecko may need this (See w3c#1802 (comment)) Closes w3c#1802
The previous prose allowed for variations not used in actual implementations. Since there is interoperability, the spec should align. Closes w3c#1804
Final tweaks about line-height. Closes the w3c#1796 series.
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Nov 27, 2017
These match with the spec changes in w3c/csswg-drafts#1993 regarding the line-height property. The odd numbering starting at 201 rather that 001 is to avoid clashing with existing similarly named tests.
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Nov 27, 2017
These match with the spec changes in w3c/csswg-drafts#1993 regarding the height of the content area of inline boxes.
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Nov 27, 2017
These test whether the the ex and ch units correctly depend on the first font **that contains U+0020**, rather than the first font at all. This matches the resolution from w3c/csswg-drafts#1765, and the spec pull request in w3c/csswg-drafts#1993
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Nov 27, 2017
These test whether the line-height calculations define in CSS2.1 correctly depend on the first font **that contains U+0020**, rather than the first font at all. This matches the resolution from w3c/csswg-drafts#1798, and the spec pull request in w3c/csswg-drafts#1993
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Nov 27, 2017
This tests whether the inline box content height calculations defined in CSS2.1 correctly depend on the first font **that contains U+0020**, rather than the first font at all. This matches the resolution from w3c/csswg-drafts#1798, and the spec pull request in w3c/csswg-drafts#1993
svgeesus
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 1, 2017
[css2][css-fonts] Tests to go with w3c/csswg-drafts#1993
|
ping @bert-github @dbaron @fantasai @FremyCompany @litherum @svgeesus for review. |
svgeesus
reviewed
Dec 4, 2017
There was a problem hiding this comment.
The changes to Fonts 3 and Fonts 4 seem good to me. It is odd to edit both Fonts.src.html and Fonts.src.html as the latter is generated from the former; harmless though.
The changes section in Fonts.src.html needs to be updated to note this change.
I'm commenting rather than approving because I lost track of which spec in which directory we are editing for CSS 2.1 second edition or 2.2 or whatever we are calling the one with actual changes and not just errata; so could someone else please check that part.
Edit: ok LGTM
|
I edited both the source and the output because I made that edit while I my application for invited expert had not yet been processed, and I therefore did not have access rights to Bert's preprocessor. I believe the manual edit matches what the processor would have done. I'm happy to regenerate if that helps with anything.As for css2.1's directories, we currently have 2: one that matches the 2.1 REC (css21), and one that has all the changes folded in (css2). I edited the later. As some other point it time, we'll have to cherry pick things from there to make a new REC, but that's a separate discussion.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of patches to apply the lessons learned in #1796 and sub-issues.
The overarching theme is to remove contradictions and ambiguities from CSS2 about line-height and to align with implementations.
I will be submitting a corresponding test pull request shortly, and cross link it with this one when I'm done.