Skip to content

Conversation

@romandev
Copy link
Member

This fixes #2460.

@romandev
Copy link
Member Author

@tabatkins, @foolip PTAL

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix the problem? Odd :)

@tabatkins
Copy link
Member

Hm, this shouldn't be necessary - I thought I allowed single-line pre just fine. (When it is multiline, I do purposely only allow the start/end tag by themselves on their line, with the content on intervening lines.) I'll look into it.

@tabatkins
Copy link
Member

Oh, I see the problem! Since I look for data-blocks before HTML parsing (so they can include things that would make HTML unhappy), I do a really minimal parse to figure out what things are.

In particular, this build error is caused by me finding that the line starts with <pre, and then seeing that it includes the substring include, which classifies it as an include-block rather than an ordinary pre. :(

I should bite the bullet and actually do a little bit of real parsing of the tag; that bit of the HTML parser isn't complicated.

@tabatkins
Copy link
Member

The build error has been fixed on Bikeshed' side, so closing this.

@tabatkins tabatkins closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cssom] Bikeshed build broken by "Use Web IDL's new-ish interface mixins concept"

3 participants