Skip to content

[cssom] Bikeshed build broken by "Use Web IDL's new-ish interface mixins concept" #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
foolip opened this issue Mar 21, 2018 · 5 comments

Comments

@foolip
Copy link
Member

foolip commented Mar 21, 2018

https://drafts.csswg.org/cssom/ hasn't been updated after #2123 and https://drafts.csswg.org/bikeshed/cssom/ says:

FATAL ERROR: Line doesn't match the grammar `k:v; k:v; k:v`:
ProcessingInstruction includes LinkStyle;
Traceback (most recent call last):
  File "/sites/api.csswg.org/bikeshed/bikeshed.py", line 5, in 
    bikeshed.main()
  File "/sites/api.csswg.org/bikeshed/bikeshed/cli.py", line 202, in main
    doc.preprocess()
  File "/sites/api.csswg.org/bikeshed/bikeshed/Spec.py", line 125, in preprocess
    self.lines = datablocks.transformDataBlocks(self, self.lines)
  File "/sites/api.csswg.org/bikeshed/bikeshed/datablocks.py", line 81, in transformDataBlocks
    doc=doc)
  File "/sites/api.csswg.org/bikeshed/bikeshed/datablocks.py", line 644, in transformInclude
    el = "
Please correct the error and update the source file.

Last Bikeshed run at 2018-03-20 15:26:10 PDT

I've also filed speced/bikeshed#1207

@foolip
Copy link
Member Author

foolip commented Mar 21, 2018

@romandev @tabatkins

@foolip
Copy link
Member Author

foolip commented Mar 21, 2018

Beyond fixing this, I wonder if Travis can be set up to try to build PRs and fail for cases like this?

romandev added a commit to romandev/csswg-drafts that referenced this issue Mar 21, 2018
romandev added a commit to romandev/csswg-drafts that referenced this issue Mar 21, 2018
@tabatkins
Copy link
Member

Any actual python errors bubbling up are serious bugs on Bikeshed's part; we should fall over noisily here so I see it and fix it.

@tabatkins
Copy link
Member

In this case, the bug is that Bikeshed is incorrectly classifying this as an include-block, because the line (a) starts with <pre, and (b) includes the substring "include". :(

speced/bikeshed#1207 is tracking this now.

@tabatkins
Copy link
Member

All fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants