[css-transforms-2] Fix translation in matrix recomposition algorithm.#2711
Merged
Conversation
You need to apply translation in all the columns. I found this while haunting a transform recomposition bug in the new Gecko style engine, which implemented this spec to the letter. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1459403
emilio
added a commit
to emilio/csswg-drafts
that referenced
this pull request
May 28, 2018
…rithm. Similar to w3c#2711. You really need to go through all the rows. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1459403
emilio
added a commit
to emilio/csswg-drafts
that referenced
this pull request
May 28, 2018
…rithm. Similar to w3c#2711. You really need to go through all the columns. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1459403
dirkschulze
approved these changes
May 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You need to apply translation in all the columns.
I found this while hunting a transform recomposition bug in the new Gecko style
engine, which implemented this spec to the letter.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1459403