Skip to content

[css-transforms-2] Fix translation in matrix recomposition algorithm. #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dirkschulze merged 1 commit into from
May 29, 2018
Merged

[css-transforms-2] Fix translation in matrix recomposition algorithm. #2711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[css-transforms-2] Fix translation in matrix recomposition algorithm. 
You need to apply translation in all the columns.

I found this while haunting a transform recomposition bug in the new Gecko style
engine, which implemented this spec to the letter.

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1459403
  • Loading branch information
@emilio
emilio committed May 28, 2018
commit e61c67bae44314facfa5b605db593fbcdca96580
2 changes: 1 addition & 1 deletion css-transforms-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,7 +1044,7 @@ for (i = 0; i < 4; i++)
matrix[i][3] = perspective[i]

// apply translation
for (i = 0; i < 3; i++)
for (i = 0; i < 4; i++)
for (j = 0; j < 3; j++)
matrix[3][i] += translation[j] * matrix[j][i]

Expand Down